[Remmina Dev] Remmina code cleaning and Coding Style Policy

Johannes Weberhofer jweberhofer at weberhofer.at
Wed Feb 20 11:01:18 CET 2019


Hi Antenore!

The origin/update-de branch will be remuved after accepting the latest german translations.

Best regards,
Johannes

Am 20.02.19 um 09:00 schrieb Antenore Gatta:
> Hi again,
> 
> 
> On Wed, 20 Feb 2019 00:13:44 +0100
> Antenore Gatta <antenore at simbiosi.org> wrote:
> 
>> With the links is better:
>>
>> [0] - https://github.com/uncrustify/uncrustify
>> [1] -
>> https://gitlab.com/Remmina/Remmina/blob/master/remmina-uncrustify.cfg
>>
>> On 20.02.19 00:05, Antenore Gatta wrote:
>>> Hey, what's up fellas?
>>>
>>> In some days or few weeks, I'd like to cleanup the Remmina source
>>> code repository, removing any unneeded branches and profit to
>>> enforce a coding style policy.
>>>
>>> Concerning the repository cleanup, let me know what I _can_ or
>>> _cannot_ remove, I won’t remove anything if I don’t get an answer
>>> back from you all, so please do your home work so that I’ll be able
>>> to do a proper cleanup.
> 
> This is the list of branches to be examined:
> 
>    origin/cleancode
>    origin/css
>    origin/fileclip
>    origin/ft-update
>    origin/l10n_po-it
>    origin/l10n_po-zh-CN
>    origin/mainexp
>    origin/master
>    origin/mpdescr
>    origin/newicons
>    origin/oldmaster
>    origin/prep-rel-1.3.2
>    origin/python-binds
>    origin/rcwref
>    origin/scripts
>    origin/update-de
>    origin/yesnodiag
> 
> Have a look also in the plugins folder, we were thinking to move some
> in an external repository (xdmcp for example).
> 
> 
>>>
>>> Regarding the coding style policy, it’s not to bother you all or to
>>> create a bullish environment, but just to harmonize the Remmina
>>> code, that Today looks like a patchwork of different projects and
>>> styles.
>>>
>>> We have an uncrustify [0] configuration file [1] that was tailored
>>> to what we were thinking was good for Remmina, but I thought that
>>> we have to do a step back and decide together the style we should
>>> follow. Therefore I’ve replaced (Today) the custom uncrustify
>>> configuration file with a basic one that follows the Linux Kernel
>>> Coding Style guide.
>>>
>>> It’s a starting point and I think it’s a good one.
>>>
>>> Some spare notes:
>>>
>>> - uncrustify it’s a tool, you can use whatever you like.
>>> - I endorse the use of a git pre-commit hook to indent
>>> automatically your code, or use an IDE that can do it for you.
>>> - Giovanni and I are among those passing more time writing code,
>>> therefore if it won’t be easy to discuss or to take a decision, we
>>> will have the last word (welcome to the Remmina Republic ).
>>> - As soon as we will take a decision I’ll re-indent the whole code,
>>> this can cause merge conflicts.
>>>
>>> That’s all at the moment and I’m really eager to have your feedback.
>>>
>>> Kind regards,
>>> Antenore
>> _______________________________________________
>> devel mailing list
>> devel at lists.remmina.org
>> https://lists.remmina.org/listinfo/devel
>> https://remmina.org/
>> https://gitlab.com/Remmina/Remmina
>> https://twitter.com/RemminaProject
>> https://www.reddit.com/r/Remmina/
> 
> _______________________________________________
> devel mailing list
> devel at lists.remmina.org
> https://lists.remmina.org/listinfo/devel
> https://remmina.org/
> https://gitlab.com/Remmina/Remmina
> https://twitter.com/RemminaProject
> https://www.reddit.com/r/Remmina/
> 

-- 
Johannes Weberhofer
Weberhofer GmbH, Austria, Vienna


More information about the devel mailing list